Skip to content

BUG: Removing a nonexistent store raises a KeyError (GH3346) #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2013

Conversation

danielballan
Copy link
Contributor

No description provided.

@jreback
Copy link
Contributor

jreback commented Apr 24, 2013

can you hook up travis? (instructions in CONTRIBUTING)

@danielballan
Copy link
Contributor Author

Yes. I think it is now enabled. Thanks for walking me through this a bit.

@jreback
Copy link
Contributor

jreback commented Apr 24, 2013

did you turn it on travis too? (you have to turn on github, then login on travis to do this), then force an update!

@danielballan
Copy link
Contributor Author

I logged into Travis, flipped the switch next to pandas-danielballan, and verified that the Service Hook is there in my github settings. (When I "Test Hook," it says "Payload deployed." Success?) And I forced a push, if that's what you meant.

@ghost
Copy link

ghost commented Apr 24, 2013

daniel, wrong branch. you need to force push on remove-raises-keyerror

https://travis-ci.org/danielballan/pandas/builds

@danielballan
Copy link
Contributor Author

OK, I see that it is building the master branch, and that the last commit happens to be yours. I'm sorry if this is generating spam for you guys or clogging up the works.

I did git push -f origin remove-raises-keyerror. Yes?

@ghost
Copy link

ghost commented Apr 24, 2013

@danielballan
Copy link
Contributor Author

dallan@dielectric-pc:~/pandas-danielballan$ git push -u origin remove-raises-keyerror
Branch remove-raises-keyerror set up to track remote branch remove-raises-keyerror from origin.
Everything up-to-date

@ghost
Copy link

ghost commented Apr 24, 2013

That looks fine.

now try

git commit --amend -C HEAD # same state, new commit hash
git push -f

jreback added a commit that referenced this pull request Apr 25, 2013
BUG: Removing a nonexistent store raises a KeyError (GH3346) - thansk!
@jreback jreback merged commit 3c728a7 into pandas-dev:master Apr 25, 2013
@danielballan danielballan deleted the remove-raises-keyerror branch April 25, 2013 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants